PDA

View Full Version : Calc PID is driving me to drink



Hib Halverson
April 8th, 2018, 07:07 AM
I'm trying to make a calculated PID for idle rpm error. I've tried entering it every way I can think and the darn thing won't appear in my PIDs list. It won't even show up as an invalid PID. Here's what I have so far:

================================================== ============================
# Add slot definitions here
# --------------------------------
# See sae_generic.txt for more information on "SLOT" formats
#
#Units Low High Fmt Expression
#------------ ------------- ------------- ---- --------------------------------------------------------------






*CLC-00-004


RPM -200 200 0.0 "{SAE.RPM]-{GM.IDLRPM}"










# ================================================== ============================
*PRN - Parameter Reference Numbers
# --------------------------------
# See sae_generic.txt for more information on the *PRN section
#
#Code PRN SLOT Units System Description
#------------------------- ---- ------------ ---------------- ---------------- ------------------------------------------




CALC.RPM_ERR F110 CLC-00-004 RPM Conditions "Idle err"



Any ideas?

joecar
April 8th, 2018, 11:15 PM
Hi Hib,

You have a square-bracket here instead of a curly-brace...



*CLC-00-004


RPM -200 200 0.0 "{SAE.RPM]-{GM.IDLRPM}"

joecar
April 8th, 2018, 11:16 PM
( also make sure you have at least 2 blank lines at the end of the file )

Hib Halverson
April 8th, 2018, 11:22 PM
Hi Hib,

You have a square-bracket here instead of a curly-brace...

Pretty dumb, huh.
LOL
Guess I need a stronger pair of computer glasses...or maybe, being frustrated I started drinking and it went downhill from there.
(sigh)


( also make sure you have at least 2 blank lines at the end of the file )

Didn't think of that either.

Thanks, Joe!

joecar
April 8th, 2018, 11:28 PM
No worries... stuff happens.

Hib Halverson
April 8th, 2018, 11:35 PM
Guess I better go buy another six-pac. Even after I corrected that one character and added boocoo lines to the end of the file, that one calculated PID still won't appear.

joecar
April 8th, 2018, 11:59 PM
Ah, the other problem is that the units RPM should be rpm (lowercase)





*CLC-00-004
RPM -200 200 0.0 "{SAE.RPM]-{GM.IDLRPM}"





CALC.RPM_ERR F110 CLC-00-004 RPM Conditions "Idle err"



See attached.

Hib Halverson
April 9th, 2018, 12:55 AM
Still not working.

More beer!
:)

joecar
April 9th, 2018, 04:25 AM
Still not working.

More beer!
https://forum.efilive.com/images/smilies/smile.png

It's never too early for beer :cheers:



Try the attached calc_pids.txt (in post #7)

on PIDs tab, click on the column heading Parameter to sort on this column;
then (looking down the Parameter column) find and select the pids SAE.RPM, GM.IDLERPM, CALC.RPM_ERR...
the pid CALC.RPM_ERR should not have a red X thru it.

Hib Halverson
April 9th, 2018, 04:47 AM
It's never too early for beer :cheers:

No arguement.

Try the attached calc_pids.txt (in post #7)

on PIDs tab, click on the column heading Parameter to sort on this column;
then (looking down the Parameter column) find and select the pids SAE.RPM, GM.IDLERPM, CALC.RPM_ERR...
the pid CALC.RPM_ERR should not have a red X thru it.

Now it appears in the list, but it's has the non-supported "x" over it. Now what?

I know..more beer.

Hib Halverson
April 9th, 2018, 04:50 AM
Another beer did the trick. To get validate idle err I also had to select desired idle.

Thanks Joe.