PDA

View Full Version : PID Creation Help



y2kws6
December 19th, 2006, 10:31 AM
I must be doing something wrong but I cant get both of my calculated pids to work. I have the wideband working but I cant get the fuel pressure pid to show up. Here is my code any help is greatly appreciated.


# ================================================== ============================
# File details
# ------------
#
# This section defines various details about the file format.
*FILE
#Parameter Value Description
#---------- ---------------- ---------------------------------------------------
VERSION 7.1.1 File version
DECSEP . Decimal separator used in this file

# ================================================== ============================
# Units
# -------------------
# See sae_generic.txt for more information on the *UNITS section
*UNITS
#Code System Abbr Description
#-------- ---------- -------- -------------------------------------------------------------
AFR None AFR "Air Fuel Ratio"

# ================================================== ============================
# Add slot definitions here
# --------------------------------
# See sae_generic.txt for more information on "SLOT" formats
#
#Units Low High Fmt Expression
#------------ ------------- ------------- ---- --------------------------------------------------------------
*CLC-00-001
AFR 10.0 18.0 .1 {EXT.AD1}*1.6+10
# ================================================== ============================
*PRN - Parameter Reference Numbers
# --------------------------------
# See sae_generic.txt for more information on the *PRN section
#
#Code PRN SLOT Units System Description
#------------------------- ---- ------------ ---------------- ---------------- ------------------------------------------
CALC.AFR_WBC F001 CLC-00-001 AFR Fuel "Wide Band AFR"
# ================================================== ============================
# File details
# ------------
# This section defines various details about the file format.
*FILE
#Parameter Value Description
#---------- ---------------- ---------------------------------------------------
VERSION 7.1.1 File version
DECSEP . Decimal separator used in this file
# ================================================== ============================
# Units
# -------------------
*UNITS
#Code System Abbr Description
#-------- ---------- -------- --------------------------------------------------
psi Imperial PSI "Pounds Per Square Inch"
# ================================================== ============================
# Add slot definitions here
# --------------------------------
#Units Low High Fmt Expression
#------------ ------------- ------------- ---- ---------------------------------
*CLC-00-002
psi 0.00 100.00 .2 "({EXT.AD2}*25)-12.5"
# ================================================== ============================
*PRN - Parameter Reference Numbers
# --------------------------------
#Code PRN SLOT Units System Description
#------------- ---- ------------ ------------ ------------ ---------------------
CALC.FP F002 CLC-00-002 psi Fuel "Fuel Pressure"


The pid doesnt show up in the list of pids. I'm sure that there is something I'm missing I'm just not sure what it is.

Thanks

Tom

Tordne
December 19th, 2006, 10:44 AM
Is that all one file you posted cause it has duplicated sections.

y2kws6
December 19th, 2006, 10:46 AM
I think I fixed it. Here it is my revised code in case anyone else has the same problem. I'll test it tonight to make sure but the pid is there now.


# ================================================== ============================
# File details
# ------------
#
# This section defines various details about the file format.
*FILE
#Parameter Value Description
#---------- ---------------- ---------------------------------------------------
VERSION 7.1.1 File version
DECSEP . Decimal separator used in this file

# ================================================== ============================
# Units
# -------------------
# See sae_generic.txt for more information on the *UNITS section
*UNITS
#Code System Abbr Description
#-------- ---------- -------- -------------------------------------------------------------
AFR None AFR "Air Fuel Ratio"
psi Imperial PSI "Pounds Per Square Inch"
# ================================================== ============================
# Add slot definitions here
# --------------------------------
# See sae_generic.txt for more information on "SLOT" formats
#
#Units Low High Fmt Expression
#------------ ------------- ------------- ---- --------------------------------------------------------------
*CLC-00-001
AFR 10.0 18.0 .1 {EXT.AD1}*1.6+10
*CLC-00-002
psi 0.00 100.00 .2 "({EXT.AD2}*25)-12.5"
# ================================================== ============================
*PRN - Parameter Reference Numbers
# --------------------------------
# See sae_generic.txt for more information on the *PRN section
#
#Code PRN SLOT Units System Description
#------------------------- ---- ------------ ---------------- ---------------- ------------------------------------------
CALC.AFR_WBC F001 CLC-00-001 AFR Fuel "Wide Band AFR"
CALC.FP F002 CLC-00-002 psi Fuel "Fuel Pressure"

y2kws6
December 19th, 2006, 10:47 AM
Is that all one file you posted cause it has duplicated sections.

I think that was my problem. I'm still kind of new to this. :D

Tordne
December 19th, 2006, 11:27 AM
Thats looks better, not duplicated sections :)

joecar
December 20th, 2006, 07:28 AM
psi units are already pre-defined for you...

if your definition of psi units causes a conflict or error message, you may want to delete that one line.

Otherwise should all be fine as Andrew said.

y2kws6
December 20th, 2006, 09:01 AM
Thanks guys. The only issue I have is the when the voltage is moving around alot when I monitor the pid but the input into the ext.ad2 is steady. I have a swing of about 5 psi or around .15 volts up or down while the pressure is steady and the input is steady. Any ideas? My situation is similar to the one in this post. http://forum.efilive.com/showpost.php?p=28766&postcount=46