Auto upgrade from build 72 to build 81 kills serial wideband.

[swingtan]

Sorry, about the MIA Blacky, I just had a guy come round to pick up all the old Grey motor gear. Good work though, as usual

Simon

[joecar]

I'll try...

...
New code: ExternalPID_Index*sizeof(WORD)
...

Should that have been:

ExternalPID_Index*sizeof(Int16)

Or something like:

ExternalPID_Index*sizeof(ExternalPID_Array[1])

[Blacky]

I'll try...

Should that have been:

ExternalPID_Index*sizeof(Int16)

Or something like:

ExternalPID_Index*sizeof(ExternalPID_Array[1])

It should have been (sizeof(WORD)*8), because the value is supposed to be the bit size (not the byte size). I changed it to sizeof(WORD) which is only 2 (bytes) and so each value that was being extracted was only 2 bits apart instead of 16 bits apart.

That's assuming sizeof() *always* returns the byte count of a field where a byte is *always* 8 bits - which I am sure is the case on all Intel based Windows systems.

Regards
Paul

[joecar]

Ah, yes of course, now I see clearly... I don't know what previously happened to me... ...Ross's programming joke was still with me...

Yes I agree, sizeof(WORD) and sizeof(INT16) are 2 and not 16...

lol, we both fell into the same hole...

Does that mean if bit widths are being used a lot, then a macro like this may come in handy:

#define bit_sizeof(x) (8*sizeof(x))

[kp]

Ok, I think I have found the problem. The diff command was my friend I compared the source code from build 81 to build 82...

FWIW build 81 was broke for me using the serial wideband, 80 worked fine.

Unless the build 81 I had was really build 82

[Blacky]

FWIW build 81 was broke for me using the serial wideband, 80 worked fine.

Unless the build 81 I had was really build 82

There was a mixup for about 30 minutes when build 82 was posted and it was labeled build 81. The best thing that can happen is for build 81 and 82 to die quietly and I'll get build 83 out tonight that will fix the problem.

Regards
Paul

[kp]

There was a mixup for about 30 minutes when build 82 was posted and it was labeled build 81. The best thing that can happen is for build 81 and 82 to die quietly and I'll get build 83 out tonight that will fix the problem.

Regards
Paul

Thanks for getting it fixed, of course I ended up in that 30 minute window lol.

[Chevy366]

Was going to do some AutoVE logging last night saw the thread and canceled the session , maybe tomorrow night .
Great work on a fix .
Old Sig :Always be wary of the Software Engineer who carries a screwdriver.

[Blacky]

Was going to do some AutoVE logging last night saw the thread and canceled the session , maybe tomorrow night .
Great work on a fix .

Your signature couldn't be more accurate except to say, beware of the programmer using a power saw - I managed to cut through the power cord last time I used a power saw.

In other news a year or so ago, I managed to end up in A&E requiring stitches after watching the (professional) guys remove tiles with a jack hammer from our bathroom which was being renovated. It looked like so much fun, jack hammer verses porcelain tiles, what could be more fun that that? My wife told me not to touch the equipment, she knows me and power tools don't co-exists happily, but while they were having lunch I snuck in and had a go. Wife refused to take me to A&E, I had to convince the builder to drive me there. Got back, hand all stitched up and they were taking to a marble bath with a sledge hammer. Man I had to have a go of that!!! Well, one lump of marble in the face and one black eye later I called it quits for the day. As I've always said - I'm just a programmer.

Regards
Paul

[Chevy366]

Your signature couldn't be more accurate except to say, beware of the programmer using a power saw - I managed to cut through the power cord last time I used a power saw.

In other news a year or so ago, I managed to end up in A&E requiring stitches after watching the (professional) guys remove tiles with a jack hammer from our bathroom which was being renovated. It looked like so much fun, jack hammer verses porcelain tiles, what could be more fun that that? My wife told me not to touch the equipment, she knows me and power tools don't co-exists happily, but while they were having lunch I snuck in and had a go. Wife refused to take me to A&E, I had to convince the builder to drive me there. Got back, hand all stitched up and they were taking to a marble bath with a sledge hammer. Man I had to have a go of that!!! Well, one lump of marble in the face and one black eye later I called it quits for the day. As I've always said - I'm just a programmer.

Regards
Paul

Yeah , worked in the construction field for a while , and would get calls from ladies asking if I could fix or redo what their husbands had started or finished , I have to say Software Engineers were the worst . JK
I had a wealthy client , say to me one time , "I wish I had your talent with tools" , I looked at him and said funny I wish I had your talent for making millions .

Gil