Designing a New Custom PE Mode PID..I need help..

[joecar]

Or this:

define CALC.SELBEN to be "iff({PEMODE}, CALC.WBO2BEN, CALC.LTFTBEN)"

and then in the VE equations use {CALC.SELBEN} instead of CALC.WBO2BEN or CALC.LTFTBEN.


"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*3445.2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.SELBEN}"
"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*15/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.SELBEN}"


Question is: does iff() allow calc pids in its then and else parts...?

[5.7ute]

Simon and others:

In all honesty it is a little over my head..But your last comment makes sense. I can display it as a 0.0 or 1.0.

What am I trying to do is say if PE Mode =0, then use CLC-00-003..
If PE Mode =1.0 then use CLC-00-004..

*CLC-00-003
% 0.0 100.0 .2 "iff( {CALC.PEMODE},0)"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*3445.2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.LTFTBEN}"
VE 0.0 3.0 .4 "iff( {CALC.PEMODE},0)"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*15/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.LTFTBEN}"

*CLC-00-004
% 0.0 100.0 .2 "iff( CALC.PEMODE},1)"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA.C }+273.15)*3445.2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.BEN1}"
VE 0.0 3.0 .4 "iff( CALC.PEMODE},1)"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA.C }+273.15)*15/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.BEN1}"[/B]

I'm 'choking on the 'iff' expression. When an user is in PE Mode I want them to use the WO2BEN Pid, when they are not in PE Mode then calculate the PID using LTFTBEN.

By the way, nice vid on that brake!!!

Shawn, the method shown won't work as you need a true,false returned value for the pid. First expression after the comma is true, then the false value. So you would have something like this
*CLC-00-003
% 0.0 100.0 .2 "iff( {CALC.PEMODE},0)"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*3445.2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.LTFTBEN},{SA E.MAF.gps}*({GM.DYNAIRTMP_DMA.C}+273.15)*3445.2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.BEN1})"

VE 0.0 3.0 .4 "iff( {CALC.PEMODE},0)"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*15/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.LTFTBEN},{SAE.MAF. gps}*({GM.DYNAIRTMP_DMA.C}+273.15)*15/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.BEN1})"

I havent checked for typos but it will give you an idea.(I just fixed a couple)
Cheers Mick

[joecar]

Shawn,

The iff() function works like this:

iff(cond, x, y)

if cond is true then return x else return y.

[WeathermanShawn]

Or this:

define CALC.SELBEN to be "iff({PEMODE}, CALC.WBO2BEN, CALC.LTFTBEN)"

and then in the VE equations use {CALC.SELBEN} instead of CALC.WBO2BEN or CALC.LTFTBEN.


"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*3445.2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.SELBEN}"
"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*15/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.SELBEN}"


Question is: does iff() allow calc pids in its then and else parts...?

Still trying it..

[WeathermanShawn]

Shawn, the method shown won't work as you need a true,false returned value for the pid. First expression after the comma is true, then the false value. So you would have something like this
*CLC-00-003
% 0.0 100.0 .2 "iff( {CALC.PEMODE},0)"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*3445.2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.LTFTBEN},{SA E.MAF.gps}*({GM.DYNAIRTMP_DMA.C}+273.15)*3445.2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.BEN1})"

VE 0.0 3.0 .4 "iff( {CALC.PEMODE},0)"{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*15/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.LTFTBEN},{SAE.MAF. gps}*({GM.DYNAIRTMP_DMA.C}+273.15)*15/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.BEN1})"

I havent checked for typos but it will give you an idea.(I just fixed a couple)
Cheers Mick

Seems like it's close..For some reason it won't calculate the VE values now..I'm sure it is operator error on this end. Sounds like it is doable though?

[5.7ute]

Certainly doable. As I said there may be a few typos in the expression that will prevent it from working. Since I dont have efilive on this pc I cant get it sorted at this end for a while.

[5.7ute]

Just to add I personally wouldnt have it relying on another calc pid as this may cause slight inaccuracies in the data. I would use commanded AFR or EQ as the operator.
Also I think it should be iff( {CALC.PEMODE}=0),{SAE.MAF.gps
not iff( {CALC.PEMODE},0)"{SAE.MAF.gps

[WeathermanShawn]

Copy that on the CALC.PID being used to calculate another one. At some point I can try the 'STATE' PID Joecar mentioned.

Joe, still looking at your expressions.

Everything seems to work, but I am not sure if I have the 'iff' set-up properly. You see it is still calculating both VE Tables..Its like I don't have the 'false' condition expressed, or it is simply a spelling or position error.

Thanks, it is a lot of work..but could make a life a lot easier for new and experienced tuners alike..

*CLC-00-002
factor 0.5 1.0 .2 "{GM.EQIVRATIO} > 1.00 & {SAE.RPM} > 2000"

*CLC-00-003
% 0.0 100.0 .2 "iff( {CALC.PEMODE}=0),{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*3445.2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.LTFTBEN}"

VE 0.0 3.0 .4 "iff( {CALC.PEMODE}=0),{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*15/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.LTFTBEN}"

*CLC-00-004
% 0.0 100.0 .2 "{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA.C}+273.15)*3445. 2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.BEN1}"

VE 0.0 3.0 .4 "{SAE.MAF.gps}*({GM.DYNAIRTMP_DMA.C}+273.15)*1 5/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.BEN1}"

[joecar]

Shawn,

Look closely at iff() syntax: iff(cond, then, else)


*CLC-00-002
factor 0.5 1.0 .2 "({GM.EQIVRATIO} > 1.00) && ({SAE.RPM} > 2000)"

*CLC-00-003
% 0.0 100.0 .2 "iff(!{CALC.PEMODE}, {SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*3445.2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.LTFTBEN}, 0)"
VE 0.0 3.0 .4 "iff(!{CALC.PEMODE}, {SAE.MAF.gps}*({GM.DYNAIRTMP_DMA. C}+273.15)*15/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.LTFTBEN}, 0)"

*CLC-00-004
% 0.0 100.0 .2 "iff({CALC.PEMODE}, {SAE.MAF.gps}*({GM.DYNAIRTMP_DMA.C}+273.15)*3445. 2/(5.669*{SAE.RPM}*{SAE.MAP.kPa})*{CALC.BEN1}, 0)"
VE 0.0 3.0 .4 "iff({CALC.PEMODE}, {SAE.MAF.gps}*({GM.DYNAIRTMP_DMA.C}+273.15)*1 5/({SAE.RPM}*{SAE.MAP.kPa})*{CALC.BEN1}, 0)"


Also note these things:

The ! operator does a NOT which inverts the logical sense,
i.e. !true = false and !false = true.

& is the bitwise AND, && is the logical AND, you need &&.


Is that what you're trying to say...?

[joecar]

Mick is correct... using calc pids in iff() seems to produce a delayed waveform.

I tried to undelay by enclosing the pids in frame( , -1) but that just produced garbage.